Fix NRCB5_MASKLWB subarray name #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Version 4.9.1rc0 of jupyter-core fixed the problem found in version 4.9.0. It sounds like 4.9.1 is going to be released imminently with this fix, so let's see if it is. If so, we can remove the update to setup.py and return this PR to its regularly scheduled programming, which is simply fixing the subarray name in the config file. |
|
Ok, this is now ready for a (trivial) review. The RTD failures have been resolved with #745 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the DMS subarray name that is associated with the NRCB5_MASKLWB aperture name in the PRD. The subarray size is 320x320 pixels, not the 640x640 pixels that the associated SW channel subarrays are.