Tweak PSF normalization limits for AMI and CLEARP #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the maximum value of the total signal in the gridded PSF library for NIRISS AMI observations. Recent updates to the NRM mask increased the total signal in the WebbPSF-created PSFs just above the previous threshold, resulting in Mirage stopping with an error that the libraries weren't normalized properly. This PR increases the maximum allowed value to account for the new NRM mask calculation.
It also pulls the custom thresholds for AMI and CLEARP observations out of catalog_seed_image.py and places them into the constants.py module, where they are a bit more obvious.