Update yaml_generator to properly handle non-sidereal sources #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhilbert4
changed the title
|
Tests show that this seems to be working well. It has revealed a bug in the pointing values that are calculated using ra_dec_update(), but the bug appears to affect all modes (not just non-sidereal) and is not caused by these changes, but instead is already present in the master branch. I'll address that in a separate issue and PR. |
bhilbert4
changed the title
|
Nevermind about the ra_dec_update bug. Turns out APT was using a different version of the PRD compared to what pysiaf was using. This was causing sources to be shifted from their expected locations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the yaml generator to calculate and use the correct pointings for non-sidereal observations, based on an ephemeris file or manually input velocity values in the non-sidereal source catalog.
Note that I made a bunch of updates to apt_inputs.py as well, and then accidentally did
git checkoutinstead ofgit addon the file, so I lost those changes and need to redo them.Resolves #588