Obs creation from segmented images #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where cases with multiple seed image files but a single dark file was failing. I made a small update to the mapping function in obs_generator for this. I found this error while running a case where the seed image was broken into 2 files (part1 and part2), while the dark image was not. This was primarily because the observation used a subarray and a SHALLOW readout pattern, and the 5x difference between the number of frames and the number of groups pushed the seed image over the file splitting threshold. With this fix, the general case where there is a different number of seed image files compared to dark files, the mapping should be done correctly.