Add file splitting to imaging mode data #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh. The failing test is the Gaia query with an error code of 500 (internal server error). Maybe we'll just wait a bit on this and see if whatever that problem is goes away, since I don't think it's related to Mirage at all. |
|
Resolves #483 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds file splitting for imaging mode observations. File splitting was already implemented for imaging TSO and grism TSO observations, but it is also possible for other modes to have observations that are large enough to trigger file splitting. This has been seen in several WFSC commissioning programs.
These changes allow for file splitting in imaging data with sidereal tracking.
Test updates with imaging observations that are both over and under the splitting limit
Test with WFSS observations both over and under the limit.
Test TSO imaging mode to make sure these changes haven't caused any errors
Test TSO grism mode to make sure these changes haven't caused any errors
These changes will not affect non-sidereal observations, nor sidereal observations that contain non-sidereal targets (e.g. background asteroids). Implementing file splitting for those modes will be much more complicated and invasive, and at the moment is lower priority.