Allow input raw dark to have no zeroframe. Create approximation. #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a small adjustment to
dark_prep.pythat allows a user to input a non-RAPID dark current ramp that has nozeroframeextension. This allows for older ground testing darks to be used as inputs.In the case where a non-RAPID dark with no zeroframe extension is provided,
dark_prep.pywill construct an approximation of the zeroframe extension by normalizing the signal in the initial group by the exposure time of a single frame. This zeroframe will be used inobs_generator.pywhen it is added to the zeroframe containing the signal of the simulated astronomical sources. This summed zeroframe is placed in the zeroframe extension of the uncal file output by Mirage. At the moment, the jwst calibration pipeline does not do anything with this extension. In the future, it will be used to calculate the signal rate for pixels that are saturated in all groups of an exposure.