Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fix for JQuery for documentation search #7524

Merged

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Apr 4, 2023

Resolves JP-3167

This PR attempts to resolve the issue with the documentation search not working - see the workaround from readthedocs/sphinx_rtd_theme#1452

Docs are built at https://jwst-pipeline--7524.org.readthedocs.build/en/7524/

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@zacharyburnett zacharyburnett self-assigned this Apr 4, 2023
@zacharyburnett zacharyburnett marked this pull request as ready for review April 4, 2023 11:39
@zacharyburnett zacharyburnett requested a review from a team as a code owner April 4, 2023 11:39
@zacharyburnett
Copy link
Collaborator Author

zacharyburnett commented Apr 4, 2023

It looks like search now works in the built docs

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (588f29d) 77.57% compared to head (742db56) 77.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7524      +/-   ##
==========================================
- Coverage   77.57%   77.56%   -0.01%     
==========================================
  Files         452      452              
  Lines       36168    36211      +43     
==========================================
+ Hits        28056    28087      +31     
- Misses       8112     8124      +12     
Flag Coverage Δ *Carryforward flag
nightly 77.57% <ø> (ø) Carriedforward from 588f29d

*This pull request uses carry forward flags. Click here to find out more.

see 28 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hbushouse hbushouse merged commit 2d9af7c into spacetelescope:master Apr 4, 2023
@zacharyburnett zacharyburnett deleted the sphinx_jquery_fix_search branch April 4, 2023 12:16
@tapastro
Copy link
Contributor

tapastro commented Apr 4, 2023

Thanks for finding the fix, Zach! 👏

@zacharyburnett
Copy link
Collaborator Author

Thanks for finding the fix, Zach! 👏

thanks but it was @braingram , I just made the PR haha

@tapastro
Copy link
Contributor

tapastro commented Apr 4, 2023

Thanks for finding the fix, Zach! 👏

thanks but it was @braingram , I just made the PR haha

Two claps, then 👏 👏 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants