-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fix for JQuery for documentation search #7524
add fix for JQuery for documentation search #7524
Conversation
It looks like search now works in the built docs |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #7524 +/- ##
==========================================
- Coverage 77.57% 77.56% -0.01%
==========================================
Files 452 452
Lines 36168 36211 +43
==========================================
+ Hits 28056 28087 +31
- Misses 8112 8124 +12
*This pull request uses carry forward flags. Click here to find out more. see 28 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Thanks for finding the fix, Zach! 👏 |
thanks but it was @braingram , I just made the PR haha |
Two claps, then 👏 👏 🙂 |
Resolves JP-3167
This PR attempts to resolve the issue with the documentation search not working - see the workaround from readthedocs/sphinx_rtd_theme#1452
Docs are built at https://jwst-pipeline--7524.org.readthedocs.build/en/7524/
Checklist for maintainers
added entry inCHANGES.rst
within the relevant release sectionupdated or added relevant testsadded relevant milestoneran regression tests, post a link to the Jenkins job below.How to run regression tests on a PR