Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JP-2669: Updating tests due to new STCAL behavior for NaNs in rateints product. #6949

Merged
merged 1 commit into from
Aug 17, 2022
Merged

JP-2669: Updating tests due to new STCAL behavior for NaNs in rateints product. #6949

merged 1 commit into from
Aug 17, 2022

Conversation

kmacdonald-stsci
Copy link
Contributor

@kmacdonald-stsci kmacdonald-stsci commented Jul 28, 2022 •
edited by hbushouse
Loading

…es and their corresponding DQ flags. The rateints product will have all NaNs set to zero with the corresponding DQ flag set to DO_NOT_USE.

Resolves JP-2669

This PR addresses testing changes needed due to updates in STCAL PR 112, which updates the way the rateints gets computed. NaNs in the rateints products are converted to 0. and the corresponding DQ value has the DO_NOT_USE flag set.

Checklist

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)

@kmacdonald-stsci kmacdonald-stsci requested a review from dmggh July 28, 2022 20:10
@hbushouse
Copy link
Collaborator

I assume that we need to wait to merge this until spacetelescope/stcal#112 gets merged, right?

@hbushouse hbushouse added this to the Build 9.0 milestone Aug 5, 2022
@kmacdonald-stsci
Copy link
Contributor Author

I assume that we need to wait to merge this until spacetelescope/stcal#112 gets merged, right?

Yes. Also I was told there has been some discussion on what to do with NaNs, so not sure how quickly we should merge either the STCAL and JWST PR's right now till we here back about this.

@kmacdonald-stsci kmacdonald-stsci force-pushed the jp_2669 branch 2 times, most recently from e02b8aa to afcb050 Compare August 10, 2022 13:42
@hbushouse hbushouse mentioned this pull request Aug 17, 2022
Merged
5 tasks
@hbushouse
Copy link
Collaborator

@kmacdonald-stsci can you rebase this to include the updates to setup that pin the version of jsonschema? All the CI's are failing because of that issue.

@kmacdonald-stsci
Updating tests due to new STCAL behavior for NaNs in integration slop…
595e148 
…es and their corresponding DQ flags. The rateints product will have all NaNs set to zero with the corresponding DQ flag set to DO_NOT_USE.

Updating the change log.
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #6949 (595e148) into master (6dc2615) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6949      +/-   ##
==========================================
- Coverage   79.27%   79.24%   -0.03%     
==========================================
  Files         414      414              
  Lines       37478    37478              
==========================================
- Hits        29709    29701       -8     
- Misses       7769     7777       +8
Flag Coverage Δ *Carryforward flag
nightly 79.23% <ø> (ø) Carriedforward from 6dc2615
unit 53.08% <ø> (-0.03%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/transforms/integration.py 76.47% <0.00%> (-5.89%) ⬇️
jwst/datamodels/container.py 81.95% <0.00%> (-2.64%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hbushouse hbushouse merged commit e8318e6 into spacetelescope:master Aug 17, 2022
@hbushouse hbushouse added the 8.1 patch PR candidate for an 8.1 patch release label Aug 31, 2022
zacharyburnett pushed a commit to zacharyburnett/jwst that referenced this pull request Aug 31, 2022
@kmacdonald-stsci @zacharyburnett
JP-2669: Updating tests due to new STCAL behavior for NaNs in rateint…
5647b4f 
…s product. (spacetelescope#6949)

Updating tests due to new STCAL behavior for NaNs in integration slopes and their corresponding DQ flags.  The rateints product will have all NaNs set to zero with the corresponding DQ flag set to DO_NOT_USE.

Updating the change log.

(cherry picked from commit e8318e6)
@hbushouse hbushouse modified the milestones: Build 9.0, Build 8.1.2 Sep 7, 2022
@kmacdonald-stsci kmacdonald-stsci deleted the jp_2669 branch November 10, 2022 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbushouse hbushouse hbushouse approved these changes

@dmggh dmggh Awaiting requested review from dmggh

Assignees
No one assigned
Labels
8.1 patch PR candidate for an 8.1 patch release ramp_fitting testing
Projects
None yet
Milestone
Build 8.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@kmacdonald-stsci @hbushouse