Responding to PR comments

spacetelescope · Aug 17, 2022 · abf8ce9 · abf8ce9
1 parent 80d31eb
commit abf8ce9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/jwst/jump/jump.py b/jwst/jump/jump.py
@@ -13,9 +13,9 @@ def run_detect_jumps(input_model, gain_model, readnoise_model,
                      max_cores, max_jump_to_flag_neighbors,
                      min_jump_to_flag_neighbors, flag_4_neighbors,
                      after_jump_flag_dn1=0.0,
-                     after_jump_flag_time1=0,
+                     after_jump_flag_time1=0.0,
                      after_jump_flag_dn2=0.0,
-                     after_jump_flag_time2=0):
+                     after_jump_flag_time2=0.0):
 
     # Runs `detect_jumps` in stcal
 
@@ -27,8 +27,8 @@ def run_detect_jumps(input_model, gain_model, readnoise_model,
     err = input_model.err
     output_model = input_model.copy()
 
-    # determine the number of groups that coorespond to the after_jump times
-    # needed as the group time is not passed to detect_jumps
+    # determine the number of groups that correspond to the after_jump times
+    # needed because the group time is not passed to detect_jumps
     gtime = input_model.meta.exposure.group_time
     after_jump_flag_n1 = int(after_jump_flag_time1 // gtime)
     after_jump_flag_n2 = int(after_jump_flag_time2 // gtime)
@@ -54,10 +54,10 @@ def run_detect_jumps(input_model, gain_model, readnoise_model,
                                     max_jump_to_flag_neighbors,
                                     min_jump_to_flag_neighbors,
                                     flag_4_neighbors, dqflags.pixel,
-                                    after_jump_flag_dn1=after_jump_flag_dn1,
-                                    after_jump_flag_n1=after_jump_flag_n1,
-                                    after_jump_flag_dn2=after_jump_flag_dn2,
-                                    after_jump_flag_n2=after_jump_flag_n2)
+                                    after_jump_flag_dn1,
+                                    after_jump_flag_n1,
+                                    after_jump_flag_dn2,
+                                    after_jump_flag_n2)
 
     # Update the DQ arrays of the output model with the jump detection results
     output_model.groupdq = new_gdq

diff --git a/jwst/jump/jump_step.py b/jwst/jump/jump_step.py
@@ -79,10 +79,10 @@ def process(self, input):
                                       rej_thresh, three_grp_rej_thresh, four_grp_rej_thresh, max_cores,
                                       max_jump_to_flag_neighbors, min_jump_to_flag_neighbors,
                                       flag_4_neighbors,
-                                      after_jump_flag_dn1=after_jump_flag_dn1,
-                                      after_jump_flag_time1=after_jump_flag_time1,
-                                      after_jump_flag_dn2=after_jump_flag_dn2,
-                                      after_jump_flag_time2=after_jump_flag_time2)
+                                      after_jump_flag_dn1,
+                                      after_jump_flag_time1,
+                                      after_jump_flag_dn2,
+                                      after_jump_flag_time2)
             gain_model.close()
             readnoise_model.close()
             tstop = time.time()