Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Fix editable install on Windows (try 2) #1234

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Apr 6, 2022

Description

This pull request is another attempt to improve quality of life for developers that have to develop Jdaviz on Windows. This is the basic fix from #1218 before we tried to get too fancy. The logic should not affect Linux/OSX at all but devs should check.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set?
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added the no-changelog-entry-needed changelog bot directive label Apr 6, 2022
@pllim pllim added this to the 2.5 milestone Apr 6, 2022
@github-actions github-actions bot added the documentation Explanation of code and concepts label Apr 6, 2022
@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #1234 (a1a3a8a) into main (d08a4ea) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1234      +/-   ##
==========================================
- Coverage   77.93%   77.84%   -0.09%     
==========================================
  Files          90       90              
  Lines        7205     7205              
==========================================
- Hits         5615     5609       -6     
- Misses       1590     1596       +6     
Impacted Files Coverage Δ
...configs/default/plugins/data_tools/file_chooser.py 65.71% <0.00%> (-3.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df79db5...a1a3a8a. Read the comment docs.

Copy link
Contributor

@javerbukh javerbukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on both MacOS and Windows! I did run into #1245 while testing on MacOS + Chrome but interestingly, I did not see the same bug on Windows + Chrome.

@pllim
Copy link
Contributor Author

pllim commented Apr 25, 2022

Just need one more approval then. @duytnguyendtn , do you want to test this out? Thanks!

@rosteen rosteen modified the milestones: 2.5, 2.6 Apr 28, 2022
@pllim
Copy link
Contributor Author

pllim commented Apr 29, 2022

I actually need this to be able to install Jdaviz dev , and given there is one approval, I am going to YOLO a bit and merge this. Thanks, all!

@pllim pllim merged commit 965be1c into spacetelescope:main Apr 29, 2022
@pllim pllim deleted the win-setup-dev-dumb-fix branch April 29, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Explanation of code and concepts no-changelog-entry-needed changelog bot directive Ready for final review
Projects
None yet
3 participants