Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCD 770 #1027

Merged
merged 13 commits into from
Feb 20, 2024
Merged

CCD 770 #1027

merged 13 commits into from
Feb 20, 2024

Conversation

hbrown-ST
Copy link
Collaborator

Reccat needed a new base rmap for niriss_mask_nrm.

@hbrown-ST hbrown-ST self-assigned this Feb 13, 2024
@hbrown-ST hbrown-ST requested a review from a team as a code owner February 13, 2024 04:49
stscieisenhamer
stscieisenhamer requested changes Feb 15, 2024
View reviewed changes
stscieisenhamer
stscieisenhamer approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@stscieisenhamer stscieisenhamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the ci failures are unrelated and unexplained, approving this particular PR. However, it would be good to build a dev container and deploy to both jwst dev and hst dev and run the tests locally there before making a release.

@hbrown-ST
Copy link
Collaborator Author

Was able to deploy changes to both HST and JWST dev machines and tests passed fine on each. The CI errors must be due to something else.

@hbrown-ST hbrown-ST merged commit e17ad9f into master Feb 20, 2024
4 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stscieisenhamer stscieisenhamer stscieisenhamer approved these changes

Assignees

@hbrown-ST hbrown-ST

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hbrown-ST @stscieisenhamer