Allow providing the key via env #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poszu
force-pushed
the
accept-key-from-env
branch
from
7c44b28
to
fb48525
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #435 +/- ##
=========================================
- Coverage 77.8% 77.6% -0.2%
=========================================
Files 25 26 +1
Lines 2010 2033 +23
=========================================
+ Hits 1565 1579 +14
- Misses 328 334 +6
- Partials 117 120 +3 ☔ View full report in Codecov by Sentry. |
fasmat
approved these changes
Nov 27, 2023
Co-authored-by: Matthias Fasching <5011972+fasmat@users.noreply.github.com>
spacemesh-bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Jan 5, 2024
## Motivation Change Poet services configuration to pass: - address - public key The public key is no longer fetched from the poet. Breaking changes: - `--poet-server` CLI argument was deprecated - new `--poet-servers` CLI argument was added. It takes a JSON-encoded list of poet servers (address and pubkey) - useful in systests - `poet-server` config field was deprecated - new config field `poet-servers` was added, which is now a struct with address and pubkey :warning: The default config was updated with poets' public keys. :warning: The config hosted for smapp needs an update for the next go-sm release cc @pigmej , @brusherru⚠️ The node will refuse the old configuration by quitting with an error message pointing the user to the upgrade information. System tests were updated to: 1. generate poet private keys 2. pass pubkey to node via `--poet-servers` 3. pass private key to poet via `POET_PRIVATE_KEY` env The system tests rely on changes in poet: spacemeshos/poet#435 (v0.10.1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to provide the private key via env variable named
POET_PRIVATE_KEY. It's meant mostly for testing (systests).