Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail new tree creation when layer files exist #414

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Oct 2, 2023

Added a check if the data dir doesn't contain any layer cache files when creating a new merkle tree.

There was a corner case that caused an invalid proof. A new merkle tree was created in a directory that contained layer cache files from a failed round recovery.

@poszu poszu added the bug label Oct 2, 2023
@poszu poszu requested a review from fasmat October 2, 2023 10:19
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #414 (5738ecc) into develop (bc84a36) will decrease coverage by 0.1%.
The diff coverage is 62.5%.

@@            Coverage Diff            @@
##           develop    #414     +/-   ##
=========================================
- Coverage     75.1%   75.1%   -0.1%     
=========================================
  Files           23      23             
  Lines         1909    1917      +8     
=========================================
+ Hits          1435    1440      +5     
- Misses         357     359      +2     
- Partials       117     118      +1     
Files Coverage Δ
prover/prover.go 62.8% <62.5%> (-0.1%) ⬇️

@poszu poszu added this pull request to the merge queue Oct 4, 2023
Merged via the queue into develop with commit 4bc1a3b Oct 4, 2023
10 of 11 checks passed
@fasmat fasmat deleted the fix-new-merkle-tree-detect-non-empty-dir branch October 5, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants