Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove open and executing round IDs from /Info GRPC endpoint #413

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Sep 28, 2023

This change removes unused fields in a backward-compatible way by marking them reserved. Neither of them is used by the node.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #413 (e62fae3) into develop (a01b21a) will decrease coverage by 0.2%.
The diff coverage is 62.5%.

@@            Coverage Diff            @@
##           develop    #413     +/-   ##
=========================================
- Coverage     74.9%   74.7%   -0.2%     
=========================================
  Files           23      23             
  Lines         1906    1892     -14     
=========================================
- Hits          1429    1415     -14     
+ Misses         359     358      -1     
- Partials       118     119      +1     
Files Coverage Δ
rpc/rpcserver.go 88.0% <ø> (+2.8%) ⬆️
registration/registration.go 75.0% <62.5%> (-0.9%) ⬇️

... and 1 file with indirect coverage changes

registration/registration.go Outdated Show resolved Hide resolved
Co-authored-by: Matthias Fasching <5011972+fasmat@users.noreply.github.com>
@poszu poszu added this pull request to the merge queue Sep 29, 2023
Merged via the queue into develop with commit 01820bd Sep 29, 2023
10 of 11 checks passed
@fasmat fasmat deleted the simplify-info-endpoint branch May 14, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants