Refactor handling submits batch to avoid stuck submits #403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
round::batch
was created on the first submit to the batch and deleted after the batch was flushed. However, there existed a corner case when the batch flush was scheduled but the submit was rejected (for example, a challenge already present in DB) leading to a situation when the batch was never flushed again.An example of this happening on the devnet-405:
Some submits time out because the flush never happens.
This PR mitigates it by:
batch.Reset()
instead of nil-ing it and recreating.