Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring the max GRPC reponse size to serve bigger proofs #395

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Sep 18, 2023

Closes #385
Configurable receive message size on the GRPC gateway to allow increasing the maximum message size that the poet is able to serve via the REST proxy. The send message size on the GRPC service is already unlimited by default.

Set the default to 8MiB.

@poszu poszu requested a review from fasmat September 18, 2023 13:10
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #395 (4d0e2ec) into develop (fb07952) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           develop    #395     +/-   ##
=========================================
- Coverage     74.8%   74.8%   -0.1%     
=========================================
  Files           23      23             
  Lines         1898    1899      +1     
=========================================
  Hits          1421    1421             
  Misses         359     359             
- Partials       118     119      +1     
Files Changed Coverage Δ
server/config.go 77.7% <ø> (ø)
server/server.go 80.3% <100.0%> (+1.3%) ⬆️

... and 1 file with indirect coverage changes

@poszu poszu added this pull request to the merge queue Sep 19, 2023
Merged via the queue into develop with commit c3507d0 Sep 19, 2023
11 checks passed
@fasmat fasmat deleted the 385-configurable-grpc-resp-size branch September 20, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring the max GRPC response size
2 participants