Poet Operator Manual. #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #391 +/- ##
=======================================
Coverage 74.8% 74.8%
=======================================
Files 23 23
Lines 1906 1906
=======================================
Hits 1426 1426
Misses 360 360
Partials 120 120 |
poszu
reviewed
Sep 13, 2023
docs/poet_operator_manual.md
Outdated
Comment on lines
9
to
11
| * https://POET_URL/v1/pow_params | ||
| nodes will query that URL to get the POW challenge parameters. | ||
| it will change every round, safe to cache in all other moments. |
There was a problem hiding this comment.
It could also change if the poet had been restarted with a different pow-difficulty, in which case the cache should be invalidated.
| > [!NOTE] | ||
| > PoET will *not* start generating tree when it will detect that the round should be already in progress but the state of the round is empty. This is to prevent the situation when PoET is doing work for nothing |
There was a problem hiding this comment.
That's not entirely true.
It will execute a round without any members. It's not optimal and could be improved.
But it will NOT create and execute an empty round when it is started in the middle of a round.
There was a problem hiding this comment.
Yeah but that's what I mean by "empty state of the round" not that it has no members but that it has not run yet etc. Could try to think how to make it more obvious.
poszu
approved these changes
Sep 20, 2023
pigmej
force-pushed
the
poet_operator_manual
branch
from
cc39840
to
54914d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.