Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject conficting challenge registrations #341

Merged
merged 5 commits into from
Aug 10, 2023

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Aug 8, 2023

Closes #340

@poszu poszu requested a review from fasmat August 8, 2023 12:20
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #341 (e2371fa) into develop (beb3bdf) will decrease coverage by 0.1%.
The diff coverage is 75.0%.

@@            Coverage Diff            @@
##           develop    #341     +/-   ##
=========================================
- Coverage     73.1%   73.1%   -0.1%     
=========================================
  Files           17      17             
  Lines         1561    1568      +7     
=========================================
+ Hits          1142    1147      +5     
- Misses         315     318      +3     
+ Partials       104     103      -1     
Files Changed Coverage Δ
service/service.go 76.2% <ø> (ø)
service/round.go 78.4% <71.4%> (-0.4%) ⬇️
rpc/rpcserver.go 78.8% <100.0%> (+0.5%) ⬆️

server/server_test.go Show resolved Hide resolved
@poszu poszu added this pull request to the merge queue Aug 10, 2023
Merged via the queue into develop with commit ec4b107 Aug 10, 2023
10 of 11 checks passed
@poszu poszu deleted the 340-reject-conflicting-challenge-registration branch August 10, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reject second registration with a different challenge
2 participants