Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --norecovery and --reset flags #313

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Jun 27, 2023

The flags are impractical and unused.

@poszu poszu requested a review from fasmat June 27, 2023 09:22
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #313 (21c20dd) into develop (58a3564) will increase coverage by 0.6%.
The diff coverage is 60.0%.

@@            Coverage Diff            @@
##           develop    #313     +/-   ##
=========================================
+ Coverage     72.5%   73.1%   +0.6%     
=========================================
  Files           17      17             
  Lines         1503    1492     -11     
=========================================
+ Hits          1090    1091      +1     
+ Misses         303     296      -7     
+ Partials       110     105      -5     
Impacted Files Coverage Δ
service/service.go 78.0% <60.0%> (+1.9%) ⬆️

... and 1 file with indirect coverage changes

@poszu poszu added this pull request to the merge queue Jun 27, 2023
Merged via the queue into develop with commit af1a560 Jun 27, 2023
8 of 9 checks passed
@fasmat fasmat deleted the remove-reset-config-flag branch September 15, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants