Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkpoint: improve HTTP error handling #6130

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Commits on Jul 11, 2024

  1. checkpoint: improve HTTP error handling

    When recovering from an URL, only continue without failing if
    checkpoint data request fails with 404 code. If the request fails
    with other 4xx HTTP error code, go-spacemesh startup fails. Upon
    other errors, including 5xx HTTP errors and network errors, retry
    checkpoint data request several times.
    `recovery.retry-count` and `recovery.retry-interval` specify retry
    parameters, defaulting to 5 and 3s, respectively.
    ivan4th committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    e581bb0 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Configuration menu
    Copy the full SHA
    05a5cf6 View commit details
    Browse the repository at this point in the history
  2. checkpoint: add --ignore-checkpoint-req-errors

    When this flag is specified, go-spacemesh doesn't exit when recovery
    URI request fails. Retries are still done, though.
    This is needed b/c in the context of TestRecovery systest, all the
    nodes are created with --recovery-uri flag passed, including the
    bootnodes. This way, they can't successfully start unless the
    bootstrapper is already running. But the bootstrapper requires an
    working go-spacemesh node to start up, thus we get a circular
    dependency.
    ivan4th committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    7ee77a1 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Address comments

    ivan4th committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    119cd53 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Fix typo

    ivan4th committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    afcac72 View commit details
    Browse the repository at this point in the history