Fix macOS linker warnings #6095
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6095 +/- ##
=========================================
- Coverage 81.7% 81.7% -0.1%
=========================================
Files 312 312
Lines 34623 34623
=========================================
- Hits 28319 28316 -3
- Misses 4468 4470 +2
- Partials 1836 1837 +1 ☔ View full report in Codecov by Sentry. |
fasmat
force-pushed
the
fix-macos-linker-warnings
branch
from
736726e
to
e1e110a
Compare
ivan4th
approved these changes
Jul 9, 2024
fasmat
force-pushed
the
fix-macos-linker-warnings
branch
from
e1e110a
to
ddbcb0a
Compare
|
Since the fix only works after we update our CI runners, I'll set this to draft for now. |
fasmat
force-pushed
the
fix-macos-linker-warnings
branch
from
ddbcb0a
to
da49306
Compare
fasmat
force-pushed
the
fix-macos-linker-warnings
branch
4 times, most recently
from
2db5f46
to
e5ba3e0
Compare
fasmat
force-pushed
the
fix-macos-linker-warnings
branch
5 times, most recently
from
14f3cab
to
765544a
Compare
fasmat
force-pushed
the
fix-macos-linker-warnings
branch
6 times, most recently
from
3a5dcf9
to
f214e52
Compare
fasmat
force-pushed
the
fix-macos-linker-warnings
branch
3 times, most recently
from
ea3c77c
to
baa7aa7
Compare
fasmat
force-pushed
the
fix-macos-linker-warnings
branch
2 times, most recently
from
dd166e1
to
9d6c587
Compare
fasmat
force-pushed
the
fix-macos-linker-warnings
branch
from
9d6c587
to
300df62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This should fix linker warnings we keep seeing on macOS.
Merge after spacemeshos/post#297
Description
Update post library and remove duplicate
LDFLAGSdefinition inMakefile.Test Plan
TODO