protocol upgrade to validate eligibility without downloading activesets #5682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atxs_by_epoch_by_pubkey|284180480wq atxs_by_epoch_pubkey_weight|281997312
dshulyak
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5682 +/- ##
=========================================
- Coverage 80.0% 80.0% -0.1%
=========================================
Files 279 279
Lines 29009 29157 +148
=========================================
+ Hits 23225 23341 +116
- Misses 4182 4207 +25
- Partials 1602 1609 +7 ☔ View full report in Codecov by Sentry. |
|
What's the status on this? Is this ready to be integrated or still WiP? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #5598
to realize proposed solution i introduced
non_decreasing_weightfor an epoch, this weight tracks the weight of all known atxs in the epoch. however for equivocating atxs we can't count weight multiple times, therefore we count only largest atx from an identity in the epoch. this way we guarantee that peers will be eventually in agreement what weight they are using for validating ballots.using that weight we compute
lower_boundary. if any ballot claims that it has lower eligibility than this boundary it is either intentionally concentrating weight or it knows about more atxs then we have locally. in 2nd case we will eventually download those atxs and validate referenced ballot.additionally we introduce
upper_boundary. this boundary computed using hardcoded minimal weight. if any ballot claims larger boundary we know that node is misconfigured or intentionally creates many small ballots for dos. in both cases we will disconnect that node with reject.