[Merged by Bors] - p2p: fix gater blocklist setup #5511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IP blockslists were not initialized properly. This change is related to #5510, but doesn't constitute a complete fix, as enabling the blocklists makes it impossible for the peers on the same LAN to talk to each other on their private IPs without involving NAT hairpinning, which may not be supported by the router or the ISP.
dshulyak
approved these changes
Jan 29, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #5511 +/- ##
=======================================
Coverage 77.6% 77.6%
=======================================
Files 268 268
Lines 31211 31200 -11
=======================================
- Hits 24242 24241 -1
+ Misses 5439 5430 -9
+ Partials 1530 1529 -1 ☔ View full report in Codecov by Sentry. |
|
bors try |
tryBuild failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jan 30, 2024
## Motivation The IP blockslists were not initialized properly. This results in "portscans", when the node tries to contact other nodes outside its local network on their private IP. See #5510 for more information
|
Build failed: |
|
Good job! |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jan 30, 2024
## Motivation The IP blockslists were not initialized properly. This results in "portscans", when the node tries to contact other nodes outside its local network on their private IP. See #5510 for more information
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
## Motivation The IP blockslists were not initialized properly. This results in "portscans", when the node tries to contact other nodes outside its local network on their private IP. See #5510 for more information
|
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
ivan4th
added a commit
that referenced
this pull request
Feb 5, 2024
## Motivation The IP blockslists were not initialized properly. This results in "portscans", when the node tries to contact other nodes outside its local network on their private IP. See #5510 for more information
ivan4th
added a commit
that referenced
this pull request
Feb 5, 2024
## Motivation The IP blockslists were not initialized properly. This results in "portscans", when the node tries to contact other nodes outside its local network on their private IP. See #5510 for more information
ivan4th
added a commit
that referenced
this pull request
Feb 5, 2024
## Motivation The IP blockslists were not initialized properly. This results in "portscans", when the node tries to contact other nodes outside its local network on their private IP. See #5510 for more information
pigmej
added a commit
that referenced
this pull request
Feb 5, 2024
Backport #5511: p2p: fix gater blocklist setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The IP blockslists were not initialized properly. This results in "portscans", when the node tries to contact other nodes outside its local network on their private IP. See #5510 for more information
Description
This fixes gater setup and adds test cases that were missing, causing the issue to be overlooked in the first place.
This change is related to #5510, but doesn't constitute a complete fix, as enabling the blocklists makes it impossible for the peers on the same LAN to talk to each other on their private IPs without involving NAT hairpinning, which may not be supported by the router or the ISP.
Test Plan
Ran a node with this patch applied