[Merged by Bors] - Check if all bytes have been consumed during scale decode #4300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
commented
Apr 14, 2023
fasmat
commented
Apr 14, 2023
Codecov Report
@@ Coverage Diff @@
## develop #4300 +/- ##
=========================================
- Coverage 76.1% 76.1% -0.1%
=========================================
Files 240 240
Lines 25100 25116 +16
=========================================
+ Hits 19117 19128 +11
- Misses 4761 4764 +3
- Partials 1222 1224 +2
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fasmat
force-pushed
the
4133-decode-messages-fully
branch
from
d734fdd
to
2231384
Compare
dshulyak
approved these changes
Apr 17, 2023
fasmat
force-pushed
the
4133-decode-messages-fully
branch
from
2231384
to
c5ded8d
Compare
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
## Motivation Closes #4133 ## Changes - `codec.Decode` was changed to check if all bytes that were provided for decoding were consumed in the process. - if not the function now returns a named error: `ErrShortRead` - In tests checking that layerID / epochID is first value in encoded bytes decoding was updated to not fail on `ErrShortRead` ## Test Plan - All existing tests pass ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
|
Pull request successfully merged into develop. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #4133
Changes
codec.Decodewas changed to check if all bytes that were provided for decoding were consumed in the process.ErrShortReadErrShortReadTest Plan
TODO
DevOps Notes