Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decoding of non-compact uints #98

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Conversation

ivan4th
Copy link
Contributor

@ivan4th ivan4th commented Sep 24, 2024

The encoder function were already there.
Also, add tests for non-compact uint encoding/decoding.

The encoder function were already there.
Also, add tests for non-compact uint encoding/decoding.
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 51.8%. Comparing base (ed76bc2) to head (b03449f).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
decoder.go 60.0% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master     #98     +/-   ##
========================================
+ Coverage    50.0%   51.8%   +1.8%     
========================================
  Files           6       6             
  Lines         891     906     +15     
========================================
+ Hits          446     470     +24     
+ Misses        376     363     -13     
- Partials       69      73      +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

decoder_test.go Outdated Show resolved Hide resolved
Copy link
Member

@fasmat fasmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a big fan of how tests in encoder_test.go and decoder_test.go are structured. They are quite hard to follow because they are so indirect and generic.

I think it would be easier to maintain those tests if they would be more explicit like in my examples above and they would hardly be longer.

decoder.go Show resolved Hide resolved
decoder_test.go Outdated Show resolved Hide resolved
encoder_test.go Outdated Show resolved Hide resolved
@ivan4th ivan4th merged commit dfa0cc4 into master Oct 9, 2024
10 checks passed
@fasmat fasmat deleted the feature/non-compact-uint branch October 9, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants