-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add decoding of non-compact uints #98
Conversation
The encoder function were already there. Also, add tests for non-compact uint encoding/decoding.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
========================================
+ Coverage 50.0% 51.8% +1.8%
========================================
Files 6 6
Lines 891 906 +15
========================================
+ Hits 446 470 +24
+ Misses 376 363 -13
- Partials 69 73 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a big fan of how tests in encoder_test.go
and decoder_test.go
are structured. They are quite hard to follow because they are so indirect and generic.
I think it would be easier to maintain those tests if they would be more explicit like in my examples above and they would hardly be longer.
The encoder function were already there.
Also, add tests for non-compact uint encoding/decoding.