Add functions that get max slice elements from struct tags #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #83 +/- ##
========================================
+ Coverage 39.1% 41.8% +2.6%
========================================
Files 5 6 +1
Lines 697 720 +23
========================================
+ Hits 273 301 +28
+ Misses 399 384 -15
- Partials 25 35 +10 ☔ View full report in Codecov by Sentry. |
3 tasks
fasmat
approved these changes
Mar 26, 2024
tag.go
Outdated
| // the struct passed as the v argument based on the 'scale' tag. It returns an error if v | ||
| // is not a structure, if max is not specified for the field, the field doesn't exist or | ||
| // there's a problem parsing the tag. | ||
| func GetMaxElementsFromValue(v any, fieldName string) (uint32, error) { |
There was a problem hiding this comment.
The Get prefix for a function/method is usually redundant and unusual for go.
Suggested change
| func GetMaxElementsFromValue(v any, fieldName string) (uint32, error) { | |
| func MaxScaleElementsForField(v any, fieldName string) (uint32, error) { |
tag.go
Outdated
| return maxElements | ||
| } | ||
|
|
||
| func getMaxElements(tag reflect.StructTag) (uint32, error) { |
There was a problem hiding this comment.
Suggested change
| func getMaxElements(tag reflect.StructTag) (uint32, error) { | |
| func maxScaleElements(tag reflect.StructTag) (uint32, error) { |
|
Removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
MustGetMaxElementsand related functions that parse struct tags to get max number of elements