fix: invalid local vars #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliecharra
requested review from
adamconnelly,
peterdeme,
ilya-hontarau and
a team
This fixes an issue where Terraform complains because the default of network and subnetwork is `null`. ``` │ Error: Inconsistent conditional result types │ │ on .terraform/modules/spacelift/main.tf line 6, in locals: │ 6: network = var.enable_network ? module.network.network : var.network │ ├──────────────── │ │ module.network.network is object with 16 attributes │ │ var.enable_network is true │ │ var.network is null │ │ The true and false result expressions must have consistent types. The 'true' value includes object attribute "auto_create_subnetworks", which is absent in the 'false' value. ``` The hack here is to transform those to a tuple and use the ternary operator to set the proper tuple index to use. I'm not sure why I did not catched that while working on it back in December ...
eliecharra
force-pushed
the
fix/invalid_local_vars
branch
from
f601168 to
0a5749f
Compare
peterdeme
approved these changes
Jan 13, 2025
ilya-hontarau
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where Terraform complains because the default of network and subnetwork is
null.See https://spacelift-io.app.spacelift.io/module/terraform-google-spacelift-selfhosted/run/01JH2SJSAPHDNZ01NRM3T5T7CS
The hack here is to transform those to a tuple and use the ternary operator to set the proper tuple index to use.
I'm not sure why I did not catched that while working on it back in December ...