-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: uses autoscaler module instead of repeating code #108
feat: uses autoscaler module instead of repeating code #108
Conversation
ccf916b
to
846f18c
Compare
This creates a unversioned dependency on the autoscaler module. Changes to that repo will be picked up by users of this module without any increment to the version of this module. From one init to the next, suddenly this module may do different things. I really try to avoid that kind of "automatic" implicit dependency update. Can you please at least pin the version in the module block? Or, better in my opinion, reverse the dependency. The upstream module should invoke this project. This project is the terraform module, and specializes in terraform syntax. The upstream project is just the lambda function code. |
Description of the change
This PR removes all the duplicated code from the autoscaler repo and calls it instead
Type of change
Checklists
Development
Code review