Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenTelemetry tracer #23

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Add OpenTelemetry tracer #23

merged 1 commit into from
Nov 28, 2024

Conversation

peterdeme
Copy link
Contributor

@peterdeme peterdeme commented Nov 28, 2024

For the trace dropping, I've tried multiple things:

  • custom sampler: didn't work. we dropped the parent span, but couldn't access child spans.
  • don't call span.End() for dropped spans - this works but children spans still show up in the UI
  • filter spans in otel-collector.yml - same issue, only drops the parent span

@peterdeme peterdeme requested a review from a team November 28, 2024 13:31
@peterdeme peterdeme force-pushed the add-opentelemetry branch 3 times, most recently from cfe58ca to c18e01d Compare November 28, 2024 13:34
Signed-off-by: peterdeme <snypox@gmail.com>

Try early return when dropping

Signed-off-by: peterdeme <snypox@gmail.com>
@ilya-hontarau ilya-hontarau requested a review from a team November 28, 2024 13:52
@ilya-hontarau
Copy link
Contributor

For the trace dropping, I've tried multiple things:

I think the only thing we can do is to create an issue in the otel sdk?
https://github.com/open-telemetry/opentelemetry-go/issues

@peterdeme
Copy link
Contributor Author

@ilya-hontarau I'll probably do but keep in mind that this is a fairly serious standard, so all SDKs would need to follow and implement it, so I don't have high hopes

@ilya-hontarau ilya-hontarau requested a review from a team November 28, 2024 14:25
@peterdeme peterdeme merged commit fe263c2 into main Nov 28, 2024
2 checks passed
@peterdeme peterdeme deleted the add-opentelemetry branch November 28, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants