Fully initialize the end of IO buffers #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This writes bytes past the end of the last message in a segment (Cap or otherwise) to fully initialize the buffer. Initializing these bytes avoids UB from passing a partially initialized &[u8] to pwrite_all(). Fixes spacejam#1032.
|
Great work, @divergentdave :) This was a pretty legendary bugfix, considering all of the effort that has gone into miri support to discover the bug! I'm bragging about your work on this when I'm talking with friends, by the way! There's a blog post that will feature some of this that is in the works, and I'll keep you in the loop on that so you can get final sign-off on anything that talks about your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This writes bytes past the end of the last message in a segment (
Capor otherwise) to fully initialize the buffer. Initializing these bytes avoids UB from passing a partially initialized&[u8]topwrite_all().Fixes #1032.