[ENG-1210] Navigate to location after adding it #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-1210 Redirect users to new locations once added (as long as they're not in the settings page)
The settings page rule comes from the fact that the user may be bulk-adding new locations, and having to navigate back and forth would be a nightmare. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
I feel like the checkbox should be on the left side of the label |
I'm not a UI dev so I'm not too sure, there's a bug with this branch anyway - hence why it's drafted. |
ameer2468
approved these changes
Oct 20, 2023
|
Gotta give @ameer2468 the credit for this one, he did the heavy lifting, I just added a checkbox and returned a value from the backend. Nice job man, it works great 🔥 |
iLynxcat
added
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the image below you can see the new checkbox, it is enabled by default. The mutation now returns the new location ID, which we pass back to the caller and navigate to (if the checkbox was selected).
This does indeed navigate to the location, but it does so before the indexer is invoked and therefore is entirely empty. @spacedriveapp/frontend, if you have any free time, please could you take a look at this?