Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix BankClientComponent never updating #33123

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix BankClientComponent never updating #33123

wants to merge 2 commits into from
+5 −8

Conversation

MilonPL
Copy link
Contributor

@MilonPL MilonPL commented Nov 3, 2024

About the PR

all entities with the BankClient component now get updated on passive income or whenever someone buys something

Why / Balance

bug fix

Technical details

removed the private DeductFunds method from the CargoSystem.Orders.cs in favor of UpdateBankAccount
changed the UpdateConsole method to use the UpdateBankAccount rather than writing directly to the StationBankAccount component, same for OnApproveOrderMessage method
BankBalanceUpdatedEvent actually fires now whenever the balance changes

Requirements

Breaking changes

Changelog

no fun

@MilonPL MilonPL mentioned this pull request Nov 3, 2024
Merged
1 task
@MilonPL
Copy link
Contributor Author

MilonPL commented Nov 3, 2024

test fail fake...

@MilonPL MilonPL mentioned this pull request Nov 4, 2024
Merged
@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@ScarKy0 ScarKy0 added T: Bugfix Type: Bugs and/or bugfixes P3: Standard Priority: Default priority for repository items. T: Cleanup Type: Code clean-up, without being a full refactor or feature D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Cargo/Salvage Area: Cargo department or Salvage. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 19, 2024
@Vonsant Vonsant mentioned this pull request Dec 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: Cargo/Salvage Area: Cargo department or Salvage. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted T: Bugfix Type: Bugs and/or bugfixes T: Cleanup Type: Code clean-up, without being a full refactor or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MilonPL @SlamBamActionman @ScarKy0