Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tape recorder v3 revival #32234

Closed
wants to merge 32 commits into from
Closed

tape recorder v3 revival #32234

wants to merge 32 commits into from

Conversation

deltanedas
Copy link
Contributor

@deltanedas deltanedas commented Sep 17, 2024 •
edited
Loading

About the PR

revival of #30089
refactored, microoptimised and addressing reviews
changed the weird dual-state thing to just be mode and thats it

stores the verb used, but the exact string the server picked in SendEntitySpeak can't be saved. presumably this will be possible in chat refactor, then the tape can store the exact message (including whispering, which still isnt stored right)

Why / Balance

see old pr

Technical details

Active bool changed to ActiveTapeRecorder so it can be queried for
UI uses RadioOptions instead of making them manually
most of the state is just gotten from the component instead of being sent in every bui state
it also stores the used speech verb now

Media

Pause | Record | Playback | Rewind
03:52:14

03:52:19

03:52:29

03:58:55

03:59:52

it will use a random string from the speech verb that was recorded
04:58:25

Requirements

Breaking changes

no

Changelog
🆑 BombasterDS, deltanedas

  • add: Tape recorders and cassettes can now be crafted in autolathes for recording crew speech.

@github-actions github-actions bot added Changes: UI Changes: Might require knowledge of UI design or code. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Sep 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 17, 2024 •
edited
Loading

RSI Diff Bot; head commit 00b13ea merging into 338781c
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Devices/cassette_tapes.rsi

State Old New Status
tape_greyscale Added
tape_ribbonoverlay Added

Resources/Textures/Objects/Devices/tape_recorder.rsi

State Old New Status
inhand-left Added
inhand-right Added
taperecorder_empty Added
taperecorder_idle Added
taperecorder_playing Added
taperecorder_recording Added
taperecorder_rewinding Added

Resources/Textures/Objects/Storage/boxes.rsi

State Old New Status
recorder Added

Edit: diff updated after 00b13ea

@lzk228
Copy link
Contributor

lzk228 commented Sep 17, 2024

he is cooking 🗣️🗣️🗣️

@MemesHodachy
Copy link

let him cook dat 🔥

@deltanedas
Copy link
Contributor Author

deltanedas commented Sep 17, 2024 •
edited
Loading

the whisper stuff from #17898 needs to be fixed with a chat refactor, right now if i want to have it i would need to copy paste all of its logic to hide identity in the transcript

same thing but worse for getting the exact verb that was used

@deltanedas deltanedas marked this pull request as ready for review September 17, 2024 15:59
@UrPrice
Copy link

UrPrice commented Oct 27, 2024

@metalgearsloth heyo, is it ready for review or merge? 3rd iteration of tape recorder, we soon start merge for us earlier than it will be merge to upstream

@stalengd stalengd mentioned this pull request Oct 28, 2024
Merged
5 tasks
stalengd
stalengd suggested changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@stalengd stalengd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this should be localized

Content.Shared/TapeRecorder/SharedTapeRecorderSystem.cs
var hasData = false;
var currentTime = 0f;
var maxTime = 0f;
var cassetteName = "Unnamed";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var cassetteName = "Unnamed";
var cassetteName = Loc.GetString("tape-recorder-menu-cassette-unnamed");

Resources/Locale/en-US/taperecorder/taperecorder.ftl
Comment on lines +23 to +24
tape-recorder-menu-no-cassette-label = Cassette tape is not inserted

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tape-recorder-menu-no-cassette-label = Cassette tape is not inserted
tape-recorder-menu-no-cassette-label = Cassette tape is not inserted
tape-recorder-menu-cassette-unnamed = Unnamed

@FaDeOkno FaDeOkno mentioned this pull request Nov 6, 2024
Merged
2 tasks
@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
KashRas2 pushed a commit to AdventureTimeSS14/space_station_ADT that referenced this pull request Nov 15, 2024
@FaDeOkno @Schrodinger71 @jungarikjan
Кассетный проигрыватель (#742)
2ba0ea6 
## Описание PR
<!-- Что вы изменили в этом пулл реквесте? -->
Добавлен кассетный проигрыватель. Он позволяет записывать разговоры.
ура?

## Почему / Баланс
<!-- Почему оно было изменено? Ссылайтесь на любые обсуждения или
вопросы здесь. Пожалуйста, обсудите, как это повлияет на игровой баланс.
-->
Иллюми попросил

**Ссылка на публикацию в Discord**
<!-- Укажите ссылки на соответствующие обсуждения, проблемы, баги,
заказы в разработку или предложения
- [Технические проблемы](ссылка)
- [Баги](ссылка)
- [Заказы-разработка](ссылка)
- [Предложения](ссылка)
- [Перенос контента](ссылка)-->
Всё, кроме поддержки барков и ТТСа, взято с
space-wizards/space-station-14#32234

## Техническая информация
<!-- Если речь идет об изменении кода, кратко изложите на высоком уровне
принцип работы нового кода. Это облегчает рецензирование.- -->
ничего из существующего не менялось

## Медиа
<!--
Пулл реквесты, которые вносят внутриигровые изменения (добавление
одежды, предметов, новых возможностей и т.д.), должны содержать медиа,
демонстрирующие изменения.
Небольшие исправления/рефакторы не требуют медиа.

Если Вы не уверены в том, что Ваш пулл реквест требует медиа, спросите
мейнтейнера.
-->

## Требования
<!--
В связи с наплывом ПР'ов нам необходимо убедиться, что ПР'ы следуют
правильным рекомендациям.

Пожалуйста, уделите время прочтению, если делаете пулл реквест (ПР)
впервые.

Отметьте поля ниже, чтобы подтвердить, что Вы действительно видели их
(поставьте X в скобках, например [X]):
-->
- [ ] Я прочитал(а) и следую [Руководство по созданию пулл
реквестов](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html).
Я понимаю, что в противном случае мой ПР может быть закрыт по усмотрению
мейнтейнера.
- [ ] Я добавил скриншоты/видео к этому пулл реквесту, демонстрирующие
его изменения в игре, **или** этот пулл реквест не требует демонстрации
в игре

## Критические изменения
<!--
Перечислите все критические изменения, включая изменения пространства
имён, публичных классов/методов/полей, переименования прототипов, и
предоставьте инструкции по их исправлению.
-->

**Чейнджлог**
<!--
Здесь Вы можете заполнить журнал изменений, который будет автоматически
добавлен в игру при мердже Вашего пулл реквест.

Чтобы игроки узнали о новых возможностях и изменениях, которые могут
повлиять на их игру, добавьте запись в журнал изменений.

Не считайте суффикс типа записи (например, add) "частью" предложения:
плохо: - add: новый инструмент для инженеров
хорошо: - add: добавлен новый инструмент для инженеров

Помещение имени после символа 🆑 изменит имя, которое будет
отображаться в журнале изменений (в противном случае будет
использоваться ваше имя пользователя GitHub).
Например: 🆑 AruMoon
-->

🆑 Котя
- add: Добавлен кассетный проигрыватель!

---------

Co-authored-by: Schrödinger <132720404+Schrodinger71@users.noreply.github.com>
Co-authored-by: Jungar <145219878+jungarikjan@users.noreply.github.com>
@eoineoineoin eoineoineoin added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: New Feature Type: New feature or content, or extending existing content D2: Medium Difficulty: A good amount of codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Security Area: Security department, including Detectives, HoS and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 22, 2024
@Vonsant Vonsant mentioned this pull request Dec 6, 2024
Merged
@Strol20
Copy link
Contributor

Strol20 commented Dec 20, 2024 •
edited
Loading

Will this merged after the chat refactoring?

@deltanedas
Copy link
Contributor Author

Will this be merged

ftfy

@Strol20
Copy link
Contributor

Strol20 commented Dec 20, 2024

Sorry for my English

@deltanedas
Copy link
Contributor Author

guess maints dont want it, using it downstream then

@deltanedas deltanedas closed this Dec 21, 2024
@Strol20
Copy link
Contributor

Strol20 commented Dec 21, 2024

Please open pr. Sooner or later someone would check and merge.

@deltanedas
Copy link
Contributor Author

i dont want to deal with merge conflicts for another year when nobody cares

@deltanedas deltanedas mentioned this pull request Dec 21, 2024
Merged
2 tasks
@PursuitInAshes PursuitInAshes mentioned this pull request Dec 22, 2024
Merged
@Vonsant
Copy link

Vonsant commented Dec 24, 2024

I feel so sad right now.

@dvir001 dvir001 mentioned this pull request Dec 27, 2024
Draft
2 tasks
@NakataRin
Copy link
Contributor

With all my heart I wish for this to be implemented. But yet again, no luck

@deltanedas
Copy link
Contributor Author

notice how nobody begging for it is a maintainer... :trollface:

This was referenced Jan 3, 2025
Closed
Merged
@JIPDawg
Copy link
Contributor

JIPDawg commented Jan 3, 2025

notice how nobody begging for it is a maintainer... :trollface:

What if you became that maintainer.

@dffdff2423
Copy link
Contributor

the day deltanedas creates a discord account is the day the world ends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stalengd stalengd stalengd requested changes

Assignees
No one assigned
Labels
A: Security Area: Security department, including Detectives, HoS Changes: Sprites Changes: Might require knowledge of spriting or visual design. Changes: UI Changes: Might require knowledge of UI design or code. D2: Medium Difficulty: A good amount of codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Review Status: Requires additional reviews before being fully accepted T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.