Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinforces Command Intercom #30638

Closed
wants to merge 4 commits into from
Closed

Reinforces Command Intercom #30638

wants to merge 4 commits into from

Conversation

JustCone14
Copy link
Contributor

@JustCone14 JustCone14 commented Aug 4, 2024

About the PR

Adds the steel plating of Security intercomms into Command intercomms as well.

Why / Balance

Fixes #30637
Also it just makes sense that command would be just as reinforced as security.

Technical details

I literally just copy pasted the code from Security's Intercoms to the Command one. This does mean they share the description as well but I think it still works so I left that in.

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase (I don't think it should anyway, there's nothing new here)

Changelog

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Aug 4, 2024
@lzk228
Copy link
Contributor

lzk228 commented Aug 4, 2024

you know, now when we have two reinforced intercoms, maybe it would be better to make base reinforced intercom, and use it as a parent for both sec and command

@JustCone14
Copy link
Contributor Author

you know, now when we have two reinforced intercoms, maybe it would be better to make base reinforced intercom, and use it as a parent for both sec and command

That'd probably be for the best yeah

@EmoGarbage404 EmoGarbage404 added the S: Awaiting Changes Status: Changes are required before another review can happen label Aug 5, 2024
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Aug 5, 2024
@JustCone14 JustCone14 closed this Aug 7, 2024
@JustCone14 JustCone14 deleted the command-intercom-reinforcement branch August 7, 2024 09:21
@lzk228 lzk228 mentioned this pull request Sep 14, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

command intercom should be secured as the sec one
3 participants