Fix 6pack sprite layers not appearing #29862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a similar PR here: #29309 Going to give the same feedback. It should instead be a bool on StorageComponent that determines whether it calls SetData for StackVisuals.Hide. |
|
Oops, I didn't realize there was another PR open for this issue. I'll close this for now and reopen if CroilBird doesn't come back to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Fixes #28721
Technical details
The soda 6pack is unique in that it is the only item with ItemCounter sprite layers, but it doesn't have lid to open/close.
Things like cigarette packs and donut boxes hide or reveal the extra layers depending on if the UI is open, but with a 6pack, we want them to always be revealed.
Given this is a single special case, I just added a field to grant it an exception, and put the logic in ItemCounterSystem to avoid scrungling up anything with SharedStorageSystem, where the lid logic lives.
Media
Changelog
no cl for sprite changes/fixes