Replace obsolete EntityWhitelist IsValid usages

[Plykiya]

About the PR

EntityWhitelist?.IsValid() has a message saying that it's obsolete and to use EntityWhitelistSystem's method instead
So I changed every usage I could find with EntityWhitelistSystem.IsValid()

Why / Balance

Gets rid of some obsolete notifications... I guess?

Technical details

Kinda like how simple the code looked before I did this...

A rough summary of how I approached each case

1. Add a check for whitelist is not null in some form, kind of can't get around it
2. == true gets replaced with component.Whitelist == null ? false : _whitelist.IsValid()
3. == false gets replaced with component.Whitelist == null ? false : !_whitelist.IsValid()
4. != true gets replaced with component.Whitelist == null ? true : !_whitelist.IsValid()
5. != false gets replaced with component.Whitelist == null ? true : _whitelist.IsValid()
6. Null coalescing ?? is replaced like normal

Took me a while to figure out that the null propagating operator gets set to null in the checks which causes different scenarios based on whether it's == or !=, once I figured out that much I properly accounted for what happens when whitelist is null and now everything I tested works pretty much without issue

edit: EmoGarbage requested helper functions so now it's
2. == true gets replaced with _whitelist.IsWhitelistPass()
3. == false gets replaced with _whitelist.IsWhitelistFail()
4. != true gets replaced with _whitelist.IsWhitelistFailOrNull()
5. != false gets replaced with _whitelist.IsWhitelistPassOrNull()
along with similarly named Blacklist functions so you can write things like
_whitelist.IsWhitelistPass() && _whitelist.IsBlacklistFail()

Breaking changes

god I hope not

Changelog

nothing changed for the player experience

[EmoGarbage404]

common pattern that i know exists is nullable whitelists/blacklists that ignore each other so a helper that takes in a nullable whitelist and a nullable blacklist and performs common functions on them would be incredibly useful.

[Plykiya]

common pattern that i know exists is nullable whitelists/blacklists that ignore each other so a helper that takes in a nullable whitelist and a nullable blacklist and performs common functions on them would be incredibly useful.

where do we store helper functions in the codebase? I'd be up for it
ah, I guess it'd just be in the EntityWhitelistSystem considering the context, okay, sure

[EmoGarbage404]

yeah i feel like basically all of these should have helpers since the replacement is quite unwieldy.

I suggest:
IsWhitelistPass
IsWhitelistFail
IsBlacklistPass
IsBlacklistFail

and then probably two more for combo:
IsWhitelistPass && IsBlacklistFail
IsWhitelistFail || IsBlackListPass

[Plykiya]

yeah i feel like basically all of these should have helpers since the replacement is quite unwieldy.

I suggest: IsWhitelistPass IsWhitelistFail IsBlacklistPass IsBlacklistFail

and then probably two more for combo: IsWhitelistPass && IsBlacklistFail IsWhitelistFail || IsBlackListPass

ok there you go, it is definitely easier to read that's for sure

[deltanedas]

common pattern that i know exists is nullable whitelists/blacklists that ignore each other so a helper that takes in a nullable whitelist and a nullable blacklist and performs common functions on them would be incredibly useful.

borg lock pr had this