Ensure that cobra is executed during tests (#103). #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xfiderek
changed the title
|
Can you modify the commit message to something like the following? |
xfiderek
changed the title
xfiderek
changed the title
|
Done |
|
@xfiderek I know it built already but I'll wait for everything to build successfully before I merge. |
ivanperez-keera
force-pushed
the
issue/103
branch
from
1272eae to
22f68dc
Compare
|
I just rebased this and I plan to merge today. |
Space ROS's main Earthfile's build-testing procedure is invoked in CI to push results of tests and static code analysis. Currently, for all packages cobra-autosar.sarif results are empty. This is because cobra or some dependent executables are not found when colcon test command is invoked. This commit prefixes the call to colcon test in the Earthfile by a call to source that brings all the necessary tools and dependencies into scope.
ivanperez-keera
force-pushed
the
issue/103
branch
from
22f68dc to
aba59d0
Compare
|
There was an extra empty line at the end. I removed it and push-forced. Per our process, I'll wait for the build again. |
ivanperez-keera
approved these changes
Jan 22, 2024
spaceros/Earthfile
Outdated
| @@ -179,3 +179,4 @@ image: | |||
| ENTRYPOINT ["/ros_entrypoint.sh"] | |||
| CMD ["bash"] | |||
| SAVE IMAGE --push osrf/space-ros:latest | |||
|
|
|||
There was a problem hiding this comment.
Can you please remove this line? Thanks!
There was a problem hiding this comment.
I've fixed this one.
There was a problem hiding this comment.
Sorry, missed that comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #103.
Space ROS's main Earthfile's build-testing procedure is invoked in CI to push results of tests and static code analysis. Currently, for all packages cobra-autosar.sarif results are empty. This is because cobra or some dependent executables are not found when colcon test command is invoked.
This PR prefixes the call to colcon test in the Earthfile by a call to source that brings all the necessary tools and dependencies into scope.
Note that re-enabling cobra significantly extends
build-testingtime from 1hr 13 minutes to 1hr 55 minutes on my local machine 1.Check the files before and after for comparison:
Future work
The results on SARIF dashboard are empty anyway, despite the fix. The reason is that
levelandkindfields in results have value "unknown" 2. It can be an issue either withprocess_sarifpackage or withament_cobrapackage. I will investigate that further and raise consecutive issues.Footnotes
Time compared using
time earthly --no-cache +build-testingcommand ↩Visualizing the results from
buildfolder works, however cobra-autosar file fromprocessedfolder shows no results on dashboard. After changinglevelandkindfields in processed files, violated rules are displayed on dashboard as expected. ↩