Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add odometry node and gz bridges for Nav2 #22

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

mkhansenbot
Copy link
Contributor

Adds odometry tf publisher node and gazebo to ROS bridges. Also adds ability to stop publishing /cmd_vel messages so that Nav2 controller can send them instead.

Of note - I noticed the python node files don't have a copyright header in them, so I followed that pattern in this repo. But should they have the standard OSRF header? If so I can add that.

@Bckempa
Copy link

Bckempa commented Jan 26, 2024

If this repo builds clean in a space-ros environment we should close space-ros/space-ros#62 as cannot-reproduce

@mkhansenbot
Copy link
Contributor Author

@quarkytale, @Bckempa - do I need to make any changes?

@mkhansenbot
Copy link
Contributor Author

Updated commit messages with issue #24

@quarkytale @Bckempa @ivanperez-keera - please review and approve.

Side note, it looks like this repo isn't set up to require a review before merge. I'll see if I can change that.

@ivanperez-keera ivanperez-keera self-requested a review January 30, 2024 01:56
@ivanperez-keera ivanperez-keera merged commit a77a20f into space-ros:main Jan 30, 2024
RBinsonB added a commit to RBinsonB/demos that referenced this pull request Sep 6, 2024
Add the demo launch files and control nodes. Also adds
the controller configuration and a gazebo lunar world.

A dockerfile is included for test.
RBinsonB added a commit to RBinsonB/demos that referenced this pull request Sep 6, 2024
RBinsonB added a commit to RBinsonB/demos that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants