-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support MacOS #24
Support MacOS #24
Conversation
README.md
Outdated
|
||
| Mathod | Command | | ||
|--------|---------------------------------------------------------------------------------------------------------------| | ||
| curl | `sudo sh -c "$(curl -fsSL https://raw.githubusercontent.com/sp1thas/dropboxignore/master/utils/install.sh)"` | | ||
| wget | `sudo sh -c "$(wget -qO- https://raw.githubusercontent.com/sp1thas/dropboxignore/master/utils/install.sh)"` | | ||
| fetch | `sudo sh -c "$(fetch -o - https://raw.githubusercontent.com/sp1thas/dropboxignore/master/utils/install.sh)"` | | ||
|
||
### Installation notes for MacOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose to add these brew install
commands directly into the utils/install.sh
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good - I forgot that users of dropboxignore are pretty much guaranteed to be developers so they will definitely have homebrew
Thank you @montaguegabe for your contribution. Your documentation-related changes should also be applied in |
I can update so that the brew commands are part of the install script and modify the docs in both places |
(PyCharm gives warnings for removing quotes around "diff" so I left all the quotes after the equals signs for consistency - feel free to add commit to change further)
One thing to note actually: at least on my Mac running a |
Sorry don't merge this yet - I hadn't tested install.sh and brew doesn't work with sudo |
Ok all set! I figured out how to drop sudo for the brew commands as per the second answer on https://unix.stackexchange.com/questions/353206/is-there-a-reverse-sudo (I actually tested a mock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks :)
This issue fixes #23, a problem apparently appearing on MacOS 10.8 and above. The diff command has been changed as well on Mac. Added instructions on how to install the matching
grep
anddiff
commands, and modified the code to use them.