Profile Backups #983
Merged
Profile Backups #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's a jumping off point for the profile backup feature. Included some basic configuration options. Currently backup runs on server start-up (before the profiles are loaded into memory) and on an configurable interval. I think it still needs work. I don't like how I'm not using the backup folder names to detect which old backups should be removed, and I'm not sure about the interval implementation. Could make the clean method thinner as well.
.tmp files often appear in here
Adjusted writer code to save profiles into subfolder
…folder next to the profiles
This reverts commit bd5dd9d.
This reverts commit cdd1831.
Updates the write operations to run asynchronously.
The `dateFormat` option complicated the reliability of the clean method. Not worth it. Updated the generation method to use a static format.
…mparing backup paths
|
I think it's ready (after a quick review of the latest). Kept simple:
|
chompDev
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a jumping off point for the profile backup feature. Included some basic configuration options. Currently backup runs on server start-up (before the profiles are loaded into memory) and on a configurable interval.
I think it still needs work.