Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyboard shortcuts for "full page view" and "return to current page" #495

Closed
ckhung opened this issue Oct 3, 2020 · 5 comments
Closed

Comments

@ckhung
Copy link

ckhung commented Oct 3, 2020

feature request: keyboard shortcuts for "full page view" and "return to current page" in browser presentation mode

Thanks for writing sozi! I have been using the inkscape-plugin version 13 up until very recently.
There are two keyboard shortcuts in browser presentation mode that I miss:
"f" for showing the entire page/canvas and "=" for returning to the current page.
Can we have them back in the stand-alone version please?

Version of Sozi and other relevant software

I am running sozi 20.05.09-1589035558 on the xfce flavor of linux mint 20 ulyana.
Browser is firefox 79.0 .

Steps to reproduce the problem

Expected behavior

For the "f" key, obviously I expect to see the entire canvas when I press it.

For the "=" key, for example I would press "r" to rotate the current slide
and then press "=" and expect this slide to return to its original orientation.

Observed behavior

Nothing happens.

Hints and solutions (optional)

On a related side note, what's the key for "turning the screen black"?
While browsing existing issues looking for similar feature requests I came across the closed issue 226
"Key shortcut to turn the screen black"
but didn't see which key I can press to create this effect.
It's not documented in the "play" document"
and I failed to find it in the source code using a simple grep -ir black .
Can you please point me to the portion of the code for handling
different cases of the keyboard input? Thanks!

@aumouvantsillage
Copy link
Collaborator

I don't remember why I removed the "f" and "-" keyboard shorcuts. I'll look into it.

On a related side note, what's the key for "turning the screen black"?

The web site has been reorganized and the new address of the "play" document is https://sozi.baierouge.fr/pages/play.html
The "blank screen" feature can be activated by pressing the "." key.

@momeni
Copy link
Contributor

momeni commented Jul 21, 2021

Maybe, the f shortkey was removed because with several layers, the "full page view" would not remain well-defined. The expected zoom/rotation of each layer to correctly represent the "full page view" needs manual adjustment in the editor (maybe we can designate an specific frame as the "full page view" frame?).

By the way, I have prepared the pull request #537 in order to reintroduce the = short key (to cancel interactive zoom/rotations).

@aumouvantsillage
Copy link
Collaborator

I have pushed an implementation for these keyboard shortcuts:

  • key "A" triggers the "view all" function (formerly "full page view")
  • key "=" resets the view to the current frame. The implementation is based on the pull request by @momeni

@ckhung
Copy link
Author

ckhung commented Aug 1, 2021

Thank you, guys! You are great!

@ckhung ckhung closed this as completed Aug 1, 2021
@aumouvantsillage
Copy link
Collaborator

This feature is available in release 21.08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants