Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor]: 主题系统设计: 将 theme tokens 和 theme settings 进行合并 #379

Closed
Tracked by #480
honghuangdc opened this issue Apr 8, 2024 · 2 comments
Closed
Tracked by #480

[Refactor]: 主题系统设计: 将 theme tokens 和 theme settings 进行合并 #379

honghuangdc opened this issue Apr 8, 2024 · 2 comments

Comments

@honghuangdc
Copy link
Member

honghuangdc commented Apr 8, 2024 •
edited
Loading

当前的 theme tokens 和 theme settings 是分离的
设计缘故：
theme tokens 用于统一UI框架和UnoCSS的样式，而 theme settings 用于管理项目的一些主题配置

变更：
将 theme tokens 和 theme settings 进行合并，统一成 theme tokens，方便进行统一管理
@honghuangdc honghuangdc changed the title [Refactor] Theme System: theme tokens will be combined with theme settings [Refactor] 主题系统设计: 将 theme tokens 和 theme settings 进行合并 Apr 8, 2024
@honghuangdc
Copy link
Member Author

honghuangdc commented Apr 8, 2024 •
edited
Loading

属于破坏性更新，放到 v1.2 中，待定

@honghuangdc honghuangdc mentioned this issue May 6, 2024
Closed
5 tasks
@honghuangdc honghuangdc changed the title [Refactor] 主题系统设计: 将 theme tokens 和 theme settings 进行合并 [Refactor]: 主题系统设计: 将 theme tokens 和 theme settings 进行合并 May 6, 2024
@honghuangdc
Copy link
Member Author

暂时不考虑该变更了，破坏性更新较大

@honghuangdc honghuangdc closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2024
@honghuangdc honghuangdc mentioned this issue Jun 6, 2024
Closed
5 tasks
honghuangdc added a commit that referenced this issue Jul 19, 2024
@honghuangdc
refactor(projects): combine theme tokens and theme settings. close …
1d1b148 
…#379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@honghuangdc