port: [#4062] Log BadRequest in adapter (#6135) #265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraitersw
changed the title
Pull Request Test Coverage Report for Build 1968954497
💛 - Coveralls |
ceciliaavila
requested changes
Mar 10, 2022
ceciliaavila
requested changes
Mar 11, 2022
Comment on lines
1198
to
1203
| if (!req.body.type) { | ||
| console.warn('BadRequest: Missing activity or activity type.'); | ||
| status = StatusCodes.BAD_REQUEST; | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm not sure of adding this here. In case of an error in parseRequest, would this code be reached?
There was a problem hiding this comment.
but if i am adding this in the parserequest, how i will set bad request as a status?
ceciliaavila
approved these changes
Mar 11, 2022
FedericoBernal
approved these changes
Mar 11, 2022
|
Promoted to MS in PR# 4155 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # 4062
#minor
Description
Add warn logger when the activity hasn't a type.
Specific Changes
Tests