Skip to content

Commit

Permalink
Disable show windows on dispose (#39)
Browse files Browse the repository at this point in the history
Prevent show and focus of Hyper during auto-updates.
  • Loading branch information
dcalhoun authored Apr 15, 2018
1 parent 59fd2bf commit 5e1adeb
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
5 changes: 0 additions & 5 deletions modules/__tests__/dispose.test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
const dispose = require('../dispose');
const { generateApp } = require('../../fixtures/app');
const { showWindows } = require('../windows');
// const { unregisterShortcut } = require('hyperterm-register-shortcut')

// jest.mock('hyperterm-register-shortcut')
Expand All @@ -20,10 +19,6 @@ describe('dispose', () => {
});
});

it('shows all windows', () => {
expect(showWindows).toHaveBeenCalledTimes(1);
});

it('unsubscribes from config changes', () => {
expect(cfgUnsubscribeMock).toHaveBeenCalledTimes(1);
});
Expand Down
2 changes: 0 additions & 2 deletions modules/dispose.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
// const { unregisterShortcut } = require('hyperterm-register-shortcut')
const { showWindows } = require('./windows');

module.exports = (app, callbacks = {}) => {
const { cfgUnsubscribe, handleActivate, handleBlur } = callbacks;

showWindows(app);
// TODO: Unregister shortcut when supported
// unregisterShortcut()

Expand Down

0 comments on commit 5e1adeb

Please sign in to comment.