Fix README.md #367
Merged
Fix README.md #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation outdated since commit d5a8462
EasyAsABC123
approved these changes
May 17, 2017
|
Can you do a git commit --amend Then change the message to have a second line saying "signed-off-by: your name " |
|
It's not the last commit any longer due to the merge. Either I'll have to rebase or do from scratch. I'd do the second... Stupidly forgot to add the "obvious fix" line too. |
|
@gbrussa not stupid it happens to the best of us...and definite happens to me a ton |
EasyAsABC123
added
Priority: Low
kamaradclimber
added a commit
to criteo-forks/iis
that referenced
this pull request
Jul 18, 2017
Most of the merge work is based on the fact that pool provider has been replaced by a custom resource. From all the non-merged criteo patches: 51e609a Fix decoding of entities in XML 5034448 Clarify execute tasks 43186f1 Activate use_inline_resources 99c4187 Remove unnecessary Chef logs 280fba8 Fix regression introduced with whyrun support e85ca2f Fix the site_identifier privacy so that the execute context can use it 12ac82f Post review fixes d534851 Removed new_resource.updated_by_last_action occurences f9b773d Make the pool provider whyrun able all are either unnecessary or correctly applied * 'master' of https://github.com/chef-cookbooks/iis: (145 commits) Adds better documentation for the options parameter (sous-chefs#383) release 6.7.2 (sous-chefs#382) Fix FTP site binding error (sous-chefs#380) Release v6.7.1 (sous-chefs#379) Fix issue with guard clause missing on check (sous-chefs#378) Release v6.7.0 (sous-chefs#376) fix multiple bugs with iis_vdir iis_root iis_app for idempotency (sous-chefs#375) Release v6.6.0 (sous-chefs#373) Update appveyor.yml Enhancement module custom resource (sous-chefs#372) Fix README.md (sous-chefs#367) Release v6.5.3 (sous-chefs#371) Resolves a bug in iis_vdir also adds more liberty in config (sous-chefs#370) Refactor vdir name property to site_name (sous-chefs#359) Release v6.5.2 (sous-chefs#364) Update iis_vdir name to not require a trailing / (sous-chefs#363) Fix iis_pool identity_type issue (sous-chefs#362) Release v6.5.1 (sous-chefs#358) Add quotes to pool name (sous-chefs#357) Release v6.5.0 (sous-chefs#352) ... Change-Id: I951fb2d1788d877c98b24bb22cb5d035162e146d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation outdated since commit d5a8462
Description
Fixing documentation to match current property names
Check List