Fixing EBS Raid creation and adding Encryption option to Raid #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 |
| @@ -31,3 +33,5 @@ | |||
| attribute :disk_type, kind_of: String, default: 'standard' | |||
| attribute :disk_piops, kind_of: Integer, default: 0 | |||
| attribute :existing_raid, kind_of: [TrueClass, FalseClass] | |||
| attribute :disk_encrypted, kind_of: [TrueClass, FalseClass], default: false | |||
| attribute :disk_kms_key_id, kind_of: String | |||
There was a problem hiding this comment.
Should the :disk_kms_key_id be marked as a required parameter?
There was a problem hiding this comment.
Nope @juliandunn aws-sdk will default to one:
Default master key that protects my EBS volumes when no other key is defined
This master key is used by default if you don't define a master key when you create an encrypted resource in this service. Settings on this key cannot be modified to ensure the availability, durability and security of this key.
There was a problem hiding this comment.
What he said.
I tested it with the default key (read: no attribute provided) and it worked fine using the master key.
|
+1 - This is currently biting us too. |
|
+1 on this |
|
+1 Pls merge |
|
Is there anything I could do to help expedite this? Until this pull request is merged we're stuck on the 2.3.0 release, which has its own set of issues (it barfs in cn-north-1 for example). |
|
This PR is really straightforward, would like to know also what can be done to speed it up please. Thanks in advance! |
…berks_syntax use correct Berksfile syntax
added 6 commits
July 21, 2015 10:15
added 7 commits
July 21, 2015 10:50
Fixed permissions Fixing Raid creation issue with Snapshot_id and adding encryption passthrough Updated README.md to include Encryption parameters for ebs_raid Pulled code from sous-chefs#99 Comment cleanup Property format standardization Bring our fork up to date with AWS 2.7.0 Fixed permissions Fixing Raid creation issue with Snapshot_id and adding encryption passthrough Pulled code from sous-chefs#99 Bumped version to 14.1.0 Comment cleanup Property format standardization
Missing source/issues urls from metadata Rebase to Current AWS Master Bring our fork up to date with AWS 2.7.0 Fixing Raid creation issue with Snapshot_id and adding encryption passthrough Updated README.md to include Encryption parameters for ebs_raid
Bring our fork up to date with AWS 2.7.0 Fixed permissions Fixing Raid creation issue with Snapshot_id and adding encryption passthrough Updated README.md to include Encryption parameters for ebs_raid Pulled code from sous-chefs#99 Comment cleanup Property format standardization Bring our fork up to date with AWS 2.7.0 Fixed permissions Fixing Raid creation issue with Snapshot_id and adding encryption passthrough Pulled code from sous-chefs#99 Bumped version to 14.1.0 Comment cleanup Property format standardization Rebased Fork on Current AWS Book (2.7.2) and reversioned to our 14.2.0 Missing source/issues urls from metadata Rebase to Current AWS Master Bring our fork up to date with AWS 2.7.0 Fixing Raid creation issue with Snapshot_id and adding encryption passthrough Updated README.md to include Encryption parameters for ebs_raid Fixed permissions Fixing Raid creation issue with Snapshot_id and adding encryption passthrough Updated README.md to include Encryption parameters for ebs_raid Pulled code from sous-chefs#99 Comment cleanup Property format standardization Bring our fork up to date with AWS 2.7.0 Fixed permissions Fixing Raid creation issue with Snapshot_id and adding encryption passthrough Pulled code from sous-chefs#99 Bumped version to 14.1.0 Comment cleanup Property format standardization
# The first commit's message is: Rebased Fork on Current AWS Book (2.7.2) and reversioned to our 14.2.0 # This is the 2nd commit message: Missing source/issues urls from metadata # This is the 3rd commit message: Rebase to Current AWS Master # This is the 4th commit message: Bring our fork up to date with AWS 2.7.0
This was referenced Jul 21, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See AWS issue: #129 and #118.
This restores the ability to create EBS volumes as part of a Raid.
It also adds the required passthrough to created encrypted volumes as a Raid.