support encrypted EBS volumes #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 🍸 |
|
+1 |
1 similar comment
|
+1 |
|
+1 This is a feature very much needed. Do you also need to supply the encryption key when making a volume encrypted? |
|
@callmeradical I'll push the added param. Good catch! |
|
@callmeradical should have the extra KMS bits now! |
|
+1 for great justice |
|
+1 |
|
@cwebberOps @someara @jtimberman any chance to review this PR please? Sorry for the ping but it's for a good cause (stop the forks). |
scalp42
force-pushed
the
aws_encrypted_ebs
branch
from
9ac4c41 to
6322f5b
Compare
|
Rebased on 2.6.6 |
|
Thanks Obama, I mean @someara |
|
Stop the forks! |
This was referenced Jul 21, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I remember seeing PRs related to the
right_awsgem, so this is foraws-sdkone, now that we don't depend on the old one anymore.Per:
http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/EBSEncryption.html
and
http://docs.aws.amazon.com/sdkforruby/api/Aws/EC2/Client.html#create_volume-instance_method