Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sra_search runs even with 0 query signatures #4

Closed
ctb opened this issue Sep 22, 2022 · 2 comments · Fixed by #12
Closed

sra_search runs even with 0 query signatures #4

ctb opened this issue Sep 22, 2022 · 2 comments · Fixed by #12

Comments

@ctb
Copy link
Contributor

ctb commented Sep 22, 2022

when we mess up the query signatures we get this message:

[2022-09-22T15:37:10Z INFO  sra_search] Loaded 0 query signatures

and then

[2022-09-22T15:37:10Z INFO  sra_search] Loading siglist
[2022-09-22T15:37:10Z INFO  sra_search] Loaded 5000 sig paths in siglist
[2022-09-22T15:37:10Z INFO  sra_search] Processed 0 search sigs
[2022-09-22T15:38:23Z INFO  sra_search] Processed 1000 search sigs
[2022-09-22T15:39:58Z INFO  sra_search] Processed 2000 search sigs

it seems like it would be good to error-exit when no query signatures are loaded :)

@ccbaumler
Copy link

ccbaumler commented Sep 22, 2022

This was a result of a scaled value mismatch. The query signature was scaled at 2000 while the signatures searched were scaled at 1000. This was verified by manually overriding the scaled value.

See #2

A possible starting point for this issue could be at this error message in the main.rs file

@ctb
Copy link
Contributor Author

ctb commented Sep 22, 2022

I think there are two separate problems -

first, sra_search runs even when there are no query signatures. (this issue)

second, sra_search silently fails to load query signatures that are not at the precise scaled specified by --scaled, which defaults to 1000 (#2)

and now third, sra_search loudly fails to load subject signatures at the wrong scaled value even when it could just downsample them - see #6.

@luizirber luizirber mentioned this issue Oct 2, 2022
luizirber added a commit that referenced this issue Oct 2, 2022
Fixes #4 #6
Closes #10 

Bring a few bits from sourmash-bio/sourmash#2230
to support the proper query config (scaled considering downsampling,
both of queries and DB sigs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants