MRG: update --save-matches code a bit.
#420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Thank you!! |
mr-eyes
added a commit
that referenced
this pull request
Aug 17, 2024
* following pyp3 sig from PyO3/pyo3#2702 * initialy working * writing to a sourmash sig instead * now faster * fix * [WIP] optional save-matches * [DONE] optional save-matches fastmultigather * add a simple test * fix name * doc * f,t * Remove test line * resolve comments * resolve comments * remove testing line * MRG: update `--save-matches` code a bit. (#420) * add pyo3 decoration * do not ignore result * fix fmt * remove redundant * MRG: more updates for `--save-matches` (#423) * make use of in_directory * add more tests --------- Co-authored-by: C. Titus Brown <titus@idyll.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: PR into #397
This PR makes a few minor adjustments to #397.