New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should downsample_* methods be inplace (instead of returning a new copy)? #618

Closed

luizirber opened this issue Jan 10, 2019 · 1 comment · Fixed by #1128

Member

luizirber commented Jan 10, 2019

https://github.com/dib-lab/sourmash/blob/314bd8e06025d0fd22c37fced0fa5f22aa832a4f/sourmash/_minhash.pyx#L248-L291

It's better to make a explicit copy if needed than do a new copy by default.

@ctb comment: " got a little bit wary of modifying minhashes in place a while back after running into some problems with md5sums changing"

Contributor

ctb commented Jul 2, 2020

yes, I think the answer to the top level issue here is "no", but want to leave this open until I review MinHash API per #885

ctb mentioned this issue

settle on core MinHash object API #885

Open

ctb mentioned this issue

[MRG] MinHash class refactoring #1128

Merged

19 tasks

ctb closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment